Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes do not honor time format settings #28863

Closed
paulchen opened this issue Apr 10, 2023 · 1 comment · Fixed by #28912
Closed

Quotes do not honor time format settings #28863

paulchen opened this issue Apr 10, 2023 · 1 comment · Fixed by #28912

Comments

@paulchen
Copy link

Description:

The timestamp given in a quoted message does not honor time format settings (global and/or user-dependent).

Steps to reproduce:

  1. Login with an admin.
  2. In Administration -> Settings -> Message, reset "Time Format" to its default value LT.
  3. In My Account -> Preferences -> Localization, set the "Language" to "English".
  4. In My Account -> Preferences -> Messages, reset the "Time Format" to "Default".
  5. Write a message quoting another one.
  6. Look at the timestamp of the quoted message.
  7. In Administration -> Settings -> Message, set "Time Format" to LTS.
  8. Look at the timestamp of the quoted message.
  9. In Administration -> Settings -> Message, reset "Time Format" to its default value LT.
  10. In My Account -> Preferences -> Messages, set the "Time Format" to "24-hour clock".
  11. Look at the timestamp of the quoted message.

Expected behavior:

In step 6, I would expect the timestamp to read 11:08 PM.

In step 8, I would expect the timestamp to read 11:08:28 PM.

In step 11, I would expect the timestamp to read 23:08.

Actual behavior:

The timestamp is always shown as 11:08 PM.

Step 6:

image

Step 8:

image

Step 11:

image

Server Setup Information:

  • Version of Rocket.Chat Server: 6.1.1
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • MongoDB Version: 6.0.5

Client Setup Information

The issue seems to occur with any combination of client and operating system.

  • Browser Version:
    • Chromium Version 112.0.5615.49 (Offizieller Build) Arch Linux (64-Bit)
    • Firefox 111.0.1 (64-bit)
  • Operating System: Arch Linux

Additional context

The issue is further complicated by the user's language setting. I only documented what's happening in English.

In #25034, a similar issue is reported regarding the timestamp in the sidebar.

@ayush3160
Copy link
Contributor

I am working on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants