Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User password change fails (by admin) and triggers rate-limiter message #5491

Closed
Sing-Li opened this issue Jan 10, 2017 · 2 comments · Fixed by #6659
Closed

User password change fails (by admin) and triggers rate-limiter message #5491

Sing-Li opened this issue Jan 10, 2017 · 2 comments · Fixed by #6659

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Jan 10, 2017

Your Rocket.Chat version: 0.49-develop

Also happens on 0.48.2

To reproduce:

As an admin, select an existing user, choose EDIT, change her/his password.

The password change fails and a "toast" from rate-limiter popsup, warning of too many calls made in too short a time.

@Sing-Li Sing-Li changed the title Admin user password change fails and triggers rate-limiter message User password change fails (by admin) and triggers rate-limiter message Jan 10, 2017
@engelgabriel engelgabriel added this to the 0.52.0 milestone Feb 4, 2017
@engelgabriel engelgabriel modified the milestones: 0.52.0, 0.53.0 Feb 14, 2017
@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.53.0 Mar 2, 2017
@engelgabriel
Copy link
Member

@MartinSchoeler can you please test if this is still happening?

@MartinSchoeler
Copy link
Contributor

MartinSchoeler commented Mar 3, 2017

@Sing-Li @engelgabriel Tested on latest develop and it worked fine, when you first change the password, its successful. And after that you have to wait 60 seconds to change it again.
Update: Just realized now that admin users should not have this limiter, so you are right this is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants