fix(mp3-encoder): Fork LAME implementation #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tassoevan
force-pushed
the
fix/mp3-encoder
branch
from
8fea59d to
b06db31
Compare
tassoevan
force-pushed
the
fix/mp3-encoder
branch
from
3f93393 to
1c6e177
Compare
tassoevan
force-pushed
the
fix/mp3-encoder
branch
from
1c6e177 to
f101865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It forks the previously used liblame port, converts it to TypeScript, strips out unused code based on our configuration defaults, and fixes a lot of problems with circular dependencies that made our previous builds absolutely defective.
Issue(s)
Further comments