Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MultiSelect close on click when opened #418

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

Kartik18g
Copy link
Contributor

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

#417 by PriyaBihani resolves #412, this PR extends it to multi-select as well.
Previously
https://user-images.githubusercontent.com/70897225/112707552-49f4fa00-8ed2-11eb-8760-6ffa6ab790d7.mov
Now
https://user-images.githubusercontent.com/70897225/112707563-5b3e0680-8ed2-11eb-9f2d-92e5235b239b.mov

Issue(s)

Further comments

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 27, 2021

This pull request introduces 1 alert and fixes 2 when merging f5b51ae into ba0eb1c - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 1 for Implicit operand conversion
  • 1 for Use of returnless function

@tiagoevanp tiagoevanp requested a review from ggazzo April 19, 2021 18:38
@tiagoevanp tiagoevanp changed the title [IMPROVE]Select: option don't toggle on clicking the close icon for multi select fix: MultiSelect close on click when opened Apr 19, 2021
@ggazzo ggazzo merged commit 1e4b30b into RocketChat:develop Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select: option don't toggle on clicking the close icon
3 participants