Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prefer null over undefined on BoxTransforms #426

Merged
merged 1 commit into from
Apr 14, 2021
Merged

fix: Prefer null over undefined on BoxTransforms #426

merged 1 commit into from
Apr 14, 2021

Conversation

tassoevan
Copy link
Collaborator

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

React 17 warns against undefined as context value because it assumes it was not properly set. This PR changes it to null.

Issue(s)

Further comments

@tassoevan tassoevan requested a review from a team April 6, 2021 14:20
@ggazzo ggazzo merged commit 9cba6b8 into develop Apr 14, 2021
@ggazzo ggazzo deleted the fix/undefined-boxtransforms branch April 14, 2021 16:37
gabriellsh added a commit that referenced this pull request Apr 26, 2021
@gabriellsh
Merge branch 'new/dropdown' of github.com:RocketChat/Rocket.Chat.Fuse…
385ea32 
…lage into new/dropdown

* 'new/dropdown' of github.com:RocketChat/Rocket.Chat.Fuselage:
  feat: @rocket.chat/string-helpers (#431)
  Fix develop (#432)
  fix: Hollow shapes for status (#430)
  fix: Modal close button size (#420)
  new: Add shredder icon for OTR messages (#423)
  fix: Change highlighted style (#422)
  fix: Tabs design update (#427)
  chore(build): Remove CircleCI configuration
  fix: Prefer null over undefined on BoxTransforms (#426)
  fix: Add more props to Throbber type definition (#429)
  fix: Remove reference to inexistent interface (#424)
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo