-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onboarding-ui): Administrator information form and Organization information form #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
force-pushed
the
new/admin-org-form
branch
from
July 5, 2021 16:12
94ea00c
to
c3a21a5
Compare
gabriellsh
reviewed
Jul 6, 2021
gabriellsh
reviewed
Jul 6, 2021
tassoevan
changed the title
new: admin & org form
new: Administrator information form and Organization information form
Jul 7, 2021
tassoevan
requested changes
Jul 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Form
component and its subcomponents would be better located under common/
. I believe forms/
should contain the implementations.
dougfabris
force-pushed
the
new/admin-org-form
branch
from
July 7, 2021 20:26
ca2f647
to
74c2ade
Compare
dougfabris
force-pushed
the
new/admin-org-form
branch
from
July 7, 2021 23:19
25f8908
to
c3ed53e
Compare
dougfabris
force-pushed
the
new/admin-org-form
branch
from
July 7, 2021 23:29
c3ed53e
to
52a0d76
Compare
tassoevan
changed the title
new: Administrator information form and Organization information form
feat(onboarding-ui): Administrator information form and Organization information form
Jul 9, 2021
…into new/admin-org-form
tassoevan
approved these changes
Jul 12, 2021
gabriellsh
added a commit
that referenced
this pull request
Aug 13, 2021
…into new/image-manipulation * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: (23 commits) fix: modal styles feat(onboarding-ui): Create Cloud Workspace Form (#499) Pass style-loader output into babel-loader Check ES version after bundling Fuselage fix(onboarding-ui): Labels wrapping under checkbox (#509) chore(fuselage): Nested sidebar props type (#510) feat(onboarding-ui): Request trial form (#505) v0.28.0 fix: Missing Sidebar type (#506) fix: Missing Sidebar type (#506) docs(github): Update pull request template (#504) fix: Escape trademark sign (#500) feat(onboarding-ui): AdminInfoPage for Cloud Registration wizard (#497) feat(onboarding-ui): Self-hosted registration (#501) fix: Add Tab.Item definition (#503) fix tabs.d.ts (#502) feat(onboarding-ui): Invalid Link page (#496) feat(onboarding-ui): Server registration form (#494) feat(onboarding-ui): Administrator information form and Organization information form (#489) fix: Forwarding ref in Select components (#492) ...
This was referenced Sep 13, 2023
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Further comments