Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onboarding-ui): Request trial page #515

Merged
merged 7 commits into from
Aug 23, 2021
Merged

feat(onboarding-ui): Request trial page #515

merged 7 commits into from
Aug 23, 2021

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Aug 10, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

image

Issue(s)

Further comments

@dougfabris dougfabris requested a review from tassoevan August 19, 2021 17:59
@tassoevan tassoevan merged commit bdbae4e into develop Aug 23, 2021
@tassoevan tassoevan deleted the feat/request_page branch August 23, 2021 20:20
This was referenced Sep 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris left review comments

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabriellsh @tassoevan @dougfabris