Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(onboarding-ui): Remove manage workspace fallback #573

Merged
merged 3 commits into from
Nov 18, 2021
Merged

fix(onboarding-ui): Remove manage workspace fallback #573

merged 3 commits into from
Nov 18, 2021

Conversation

ujorgeleite
Copy link
Contributor

@ujorgeleite ujorgeleite commented Nov 18, 2021 •
edited by dougfabris
Loading

remove unnecessary components on the request trial page

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@ujorgeleite ujorgeleite requested a review from a team November 18, 2021 19:47
@dougfabris dougfabris changed the title fix: Remove manage workspace fallback fix(onboarding-ui): Remove manage workspace fallback Nov 18, 2021
@dougfabris dougfabris added the 📦 onboarding-ui @rocket.chat/onboarding-ui label Nov 18, 2021
@ujorgeleite ujorgeleite merged commit 7f0b870 into develop Nov 18, 2021
@ujorgeleite ujorgeleite deleted the remove-manage-workspace-fallback branch November 18, 2021 20:52
ggazzo pushed a commit that referenced this pull request Nov 18, 2021
@ujorgeleite @ggazzo
fix(onboarding-ui): Remove manage workspace fallback (#573)
ab0b99a 
* chore: remove unnecessary component

* chore: update loki tests image

* feat: add test to manageWorkspaceFallback
This was referenced Sep 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy left review comments

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
📦 onboarding-ui @rocket.chat/onboarding-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ujorgeleite @geekgonecrazy @dougfabris