Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onboarding-ui): add oauth auth page #586

Merged
merged 4 commits into from
Dec 14, 2021
Merged

feat(onboarding-ui): add oauth auth page #586

merged 4 commits into from
Dec 14, 2021

Conversation

PedroRorato
Copy link
Contributor

@PedroRorato PedroRorato commented Dec 13, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@PedroRorato PedroRorato force-pushed the oauth-auth-page branch 2 times, most recently from 35123c3 to 276a09a Compare December 13, 2021 20:16
@PedroRorato PedroRorato marked this pull request as ready for review December 13, 2021 21:16
@PedroRorato PedroRorato requested a review from a team December 13, 2021 21:17
@PedroRorato PedroRorato merged commit 4a7ae0b into develop Dec 14, 2021
@PedroRorato PedroRorato deleted the oauth-auth-page branch December 14, 2021 19:53
This was referenced Sep 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujorgeleite ujorgeleite ujorgeleite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PedroRorato @CLAassistant @ujorgeleite