Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fuselage-hooks): useContentBoxSize and useBorderBoxSize crashing in safari #616

Merged
merged 7 commits into from
Jan 19, 2022
Merged

fix(fuselage-hooks): useContentBoxSize and useBorderBoxSize crashing in safari #616

merged 7 commits into from
Jan 19, 2022

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jan 14, 2022 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@gabriellsh gabriellsh requested a review from a team January 14, 2022 18:24
@ghost
Copy link

ghost commented Jan 14, 2022 •
edited by ghost
Loading

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

dougfabris
dougfabris requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check the errors in this one

@dougfabris dougfabris self-requested a review January 19, 2022 11:58
@ggazzo ggazzo merged commit d1514f6 into develop Jan 19, 2022
@ggazzo ggazzo deleted the fix/resizeObserver branch January 19, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris Awaiting requested review from dougfabris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabriellsh @dougfabris @ggazzo