Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fuselage): Field.Link component #619

Merged
merged 4 commits into from
Jan 18, 2022
Merged

feat(fuselage): Field.Link component #619

merged 4 commits into from
Jan 18, 2022

Conversation

PedroRorato
Copy link
Contributor

@PedroRorato PedroRorato commented Jan 17, 2022 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@ghost
Copy link

ghost commented Jan 17, 2022 •
edited by ghost
Loading

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@PedroRorato PedroRorato marked this pull request as ready for review January 18, 2022 00:12
@tassoevan tassoevan changed the title feat(fuselage): add field link component feat(fuselage): Field.Link component Jan 18, 2022
@tassoevan tassoevan merged commit 7bce30a into develop Jan 18, 2022
@tassoevan tassoevan deleted the feat-field-link branch January 18, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

@dougfabris dougfabris Awaiting requested review from dougfabris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PedroRorato @tassoevan