Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fuselage): Code snippet component #622

Merged
merged 10 commits into from
Jan 25, 2022
Merged

feat(fuselage): Code snippet component #622

merged 10 commits into from
Jan 25, 2022

Conversation

PedroRorato
Copy link
Contributor

@PedroRorato PedroRorato commented Jan 18, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Added a new component CodeSnippet to make easier for users to copy snippets of code while configuring their server. It also creates a standard and makes easier for developers to provide this functionality to the users.

https://www.loom.com/share/03fdee62bdb04c02a1624ded69f57772

Issue(s)

Further comments

@ghost
Copy link

ghost commented Jan 18, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@PedroRorato PedroRorato marked this pull request as ready for review January 19, 2022 18:43
@dougfabris dougfabris changed the title feat: add code snippet component feat(fuselage): Code snippet component Jan 22, 2022
PedroRorato
PedroRorato commented Jan 25, 2022
View reviewed changes
Copy link
Contributor Author

@PedroRorato PedroRorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a lot better...

@PedroRorato PedroRorato merged commit 147f8a1 into develop Jan 25, 2022
@PedroRorato PedroRorato deleted the feat-code-snippet branch January 25, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

@tassoevan tassoevan Awaiting requested review from tassoevan

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PedroRorato @dougfabris