New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bundle errors #72

Merged

ggazzo merged 2 commits into develop from fix/webpack

Oct 17, 2019

Collaborator

tassoevan commented Oct 17, 2019

React was declared as an external AMD dependency instead of react;
Some build systems prefer .mjs over .js without proper parsing;
MiniCssExtractPlugin.loader cannot be used with 'style-loader' in the same chain (see https://github.com/webpack-contrib/mini-css-extract-plugin#advanced-configuration-example)

tassoevan added 2 commits

October 17, 2019 14:30


          Fix incorrect external AMD module name

dad6530


          Remove CSS extraction

6543fc8

tassoevan added the 🐛 Bug label

tassoevan requested a review from ggazzo

October 17, 2019 17:49

ggazzo merged commit 77f5c12 into develop

ggazzo deleted the fix/webpack branch

October 17, 2019 17:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels