Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): Chevron vertical position #910

Merged
merged 7 commits into from
Dec 29, 2022

Conversation

vatsilidis
Copy link
Contributor

Proposed changes (including videos or screenshots)

Add vertical center alignment at the Chevron in order to avoid positioning it at the top or at the bottom when the height of the parent container is bigger than the Chevron height.

Here are two screenshots with a title of height of 60px at the Accordion's header before and after the fix.

Screenshot 2022-11-22 at 08 52 23

Screenshot 2022-11-22 at 08 52 15

Screenshot 2022-11-22 at 08 51 26

Screenshot 2022-11-22 at 08 51 22

Issue(s)

Further comments

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022

CLA assistant check
All committers have signed the CLA.

@dougfabris dougfabris changed the title fix Chevron vertical position fix(fuselage): Chevron vertical position Nov 24, 2022
@ggazzo ggazzo requested a review from tassoevan November 26, 2022 02:57
@ggazzo
Copy link
Member

ggazzo commented Nov 26, 2022

help @tassoevan
not sure if makes sense or not, remember this component is not only used with subtitle
on rocket.chat there are some with complex (and huge forms) having the chevron centralized could be a little weird in those cases

@tassoevan
Copy link
Collaborator

It makes sense to reinforce the vertical centralization, but we don't recommend using anything beyond a plain text as the accordion's title.

@tassoevan tassoevan merged commit f086df2 into RocketChat:develop Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants