From 51b709b33bef2bec6ca7baf99a57dc311dd8c5ac Mon Sep 17 00:00:00 2001 From: Ruifeng Zheng Date: Tue, 10 Jan 2023 18:02:59 +0900 Subject: [PATCH] [SPARK-41934][CONNECT][PYTHON][FOLLOWUP] Add `Session.readStream` to the unsupported list ### What changes were proposed in this pull request? Add `Session.readStream` to the unsupported list ### Why are the changes needed? all missing API should throw `NotImplementedError` ### Does this PR introduce _any_ user-facing change? yes, `NotImplementedError` ### How was this patch tested? updated UT Closes #39478 from zhengruifeng/connect_session_missing_update. Authored-by: Ruifeng Zheng Signed-off-by: Hyukjin Kwon --- python/pyspark/sql/connect/session.py | 4 ++++ python/pyspark/sql/tests/connect/test_connect_basic.py | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/python/pyspark/sql/connect/session.py b/python/pyspark/sql/connect/session.py index 82bde57beb348..4c5ea3da10e52 100644 --- a/python/pyspark/sql/connect/session.py +++ b/python/pyspark/sql/connect/session.py @@ -400,6 +400,10 @@ def sparkContext(self) -> Any: def streams(self) -> Any: raise NotImplementedError("streams() is not implemented.") + @property + def readStream(self) -> Any: + raise NotImplementedError("readStream() is not implemented.") + @property def udf(self) -> Any: raise NotImplementedError("udf() is not implemented.") diff --git a/python/pyspark/sql/tests/connect/test_connect_basic.py b/python/pyspark/sql/tests/connect/test_connect_basic.py index c946c735a1df3..d8bde3db6d7fd 100644 --- a/python/pyspark/sql/tests/connect/test_connect_basic.py +++ b/python/pyspark/sql/tests/connect/test_connect_basic.py @@ -2136,11 +2136,15 @@ def test_unsupported_session_functions(self): with self.assertRaises(NotImplementedError): RemoteSparkSession.getActiveSession() + with self.assertRaises(NotImplementedError): + RemoteSparkSession.builder.enableHiveSupport() + for f in ( "newSession", "conf", "sparkContext", "streams", + "readStream", "udf", "version", ):