Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from internal midi message comparison on input to native JUCE #131

Open
RomanKubiak opened this issue Jan 15, 2021 · 3 comments
Open
Assignees
Labels

Comments

@RomanKubiak
Copy link
Owner

Since now JUCE has all the possibilities to match MIDI messages (single and multi-message NRPN/RPN style), we can switch to using that, some of the nasty code that I implemented could be removed and based on something that's verified and known to work.

@RomanKubiak RomanKubiak self-assigned this Jan 15, 2021
@dobo365
Copy link

dobo365 commented Jan 15, 2021

What do you mean by "possibilities to match MIDI messages"?
Actually, even if nasty code (your words), I'm quite happy and don't face issues.
Thus just be careful by just commenting the code before removing it or be prepared to un-commit changes)
I would not prioritize this change but I can understand that from a maintenance perspective it would be better so of course I support it ;-)

@Possemo
Copy link

Possemo commented Feb 15, 2021

This does not work properly indeed. In most cases sliders do not react to incoming MIDI. Would be great if that would be fixed one day. But I guess JUCE does it only for standard CC's and NRPN/RPN but probably not for sysex. BTW. with the automation parameters of the plugin there is a workaround for this: Most DAW's can assign CC's to automation parameters. This way Ctrlr works as a controller converter. You can use a simple hardware controller which only supports CC to control synths with weird sysex or NRPN's.

@Godlike-Productions
Copy link

I'm not sure if this is related but versions later than 5.3.201 don't seem to support sending MIDI from LUA using sendMidiMessageNow() when the panel is saved as a restricted instance (ie VST or VST3). It works fine with the Ctrlr VST, but as soon as it is exported, all the MIDI stops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants