Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadblock to Using Node 18 #378

Open
Urook opened this issue Apr 6, 2024 · 4 comments
Open

Roadblock to Using Node 18 #378

Urook opened this issue Apr 6, 2024 · 4 comments
Assignees

Comments

@Urook
Copy link
Contributor

Urook commented Apr 6, 2024

Hey guys, it is me :).

I see you tried migrating from node 16 to address security issues.

Here is the thing, we use electron 22, which is based on node 16, so this change might not be enough to address whatever it is you are trying to address.

However, upgrading electron is problematic, because the major we use is the last one to support windows 7 and 8 (and win server 2012) and some mac os versions.

My recommendation is as such:

Add a check if a user's os is at least win 10/win server 2016 (or 19? Check win 10 equiv in server) or oldest supported macos before checking for auto update version

Release this as a minor patch so that everyone that should stop getting auto updates due to an old os gets the patch.

Then, publish a new version with a newer electron version to make sure the priject uses node 18 :)

@Urook
Copy link
Contributor Author

Urook commented Apr 6, 2024

@Urook
Copy link
Contributor Author

Urook commented Apr 6, 2024

@FridmasterDyna

@FridmasterDyna
Copy link
Contributor

@Urook Hello! Thank you very much for addressing this info for us. I will make changes related to this issue - at the beginning of next week.

@FridmasterDyna FridmasterDyna self-assigned this Apr 6, 2024
@Urook
Copy link
Contributor Author

Urook commented Apr 8, 2024

@Urook Hello! Thank you very much for addressing this info for us. I will make changes related to this issue - at the beginning of next week.

@FridmasterDyna

Great to hear.

BTW, in case you don't know me, I am a former employee and know the system pretty well.

So, feel free to reach out if you want my help in any way, I will be glad to help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants