Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2 ungetestete AntiND Funktionalität; wartet auf #8 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PaxJaromeMalues
Copy link

Workflow PR (oderso?!)

@PaxJaromeMalues PaxJaromeMalues self-assigned this Dec 8, 2022
@PaxJaromeMalues PaxJaromeMalues linked an issue Dec 8, 2022 that may be closed by this pull request
4 tasks
Copy link

@GermanHydrogen GermanHydrogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke about this

This script does not return any values.
*/

#include "devar.sqf"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include not justified


#include "devar.sqf"

[] spawn {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary, just spawn antiNDLocalEH

RR_commons_resources_spawnPos = getPos player;
RR_commons_resources_antiNDFiredLocalEh = player addEventHandler ["Fired", {
private _munition = _this select 6;
Missiontime = call RR_commons_core_fnc_getMissionTime;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use private var

[] spawn {
// waitUntil {!isNull player}; removed as most likely not needed as fired via playerInitLocal
RR_commons_resources_spawnPos = getPos player;
RR_commons_resources_antiNDFiredLocalEh = player addEventHandler ["Fired", {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete when time is up


[] spawn {
// waitUntil {!isNull player}; removed as most likely not needed as fired via playerInitLocal
RR_commons_resources_spawnPos = getPos player;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use local variables

@@ -0,0 +1 @@
missionNamespace getVariable [RR_commons_resources_missionTime, ""];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke about this

This script does not return any values.
*/

if (isDedicated) then {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke about this

/* buildPop */
[] spawn {
waitUntil {sleep 0.1; time > 0.2};
call RR_commons_buildPop_fnc_init3denTriggers;
};

/* Mission time tracker */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke about this


/* Anti-ND */
remoteExecCall [RR_commons_antiND_fnc_safeStart, 2, false];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be local to user. Should be in initPlayerLocal

This script does not return any values.
*/

waitUntil {not isNil player};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to spawn this function because of this. isNil expression is definitly wrong

@GermanHydrogen
Copy link

allowDamage false for the duration of the save time, would be a nice addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

safe spawn and anti nd
2 participants