Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All Platforms] Scene3D needs slight fixing. #69

Closed
LittlePlanetCD opened this issue Aug 30, 2022 · 2 comments · Fixed by #103
Closed

[All Platforms] Scene3D needs slight fixing. #69

LittlePlanetCD opened this issue Aug 30, 2022 · 2 comments · Fixed by #103
Labels
bug Something isn't working rendering

Comments

@LittlePlanetCD
Copy link
Contributor

It seems like the models polygons or tri's are not exactly rendering correctly.

It was more noticable with mods like Mania repainted, but when using base mania, it's still obvious on most objects.

this is a picture of Sonic, on the decomp. notice how his hand is just slightly weird.

image

Here's the same frame and character placement, but on Sonic Mania on Steam. Notice how it doesn't have the oddity on Sonic's hand.

image

This kind of "Polygon/Tri" issue is a lot more visible if you use a mod like Mania repainted.

I may post example screenshots of those later, but it was very obvious on the homers.

@LittlePlanetCD
Copy link
Contributor Author

For a more, obvious comparison, I will be also using Mania Repainted.

the shoes of some of the homers usually look like this.

image

but look like this on the decomp.

image

there's also the more obvious polygon sort (?) on the sides of the homers, which usually looked like this on steam (and before the scene3d changes):

image

but now, after all the changes, it looks like this when it shouldn't.

image

@stxticOVFL stxticOVFL added bug Something isn't working rendering labels Aug 30, 2022
Clownacy added a commit to Clownacy/RSDKv5-Decompilation-Wii-U that referenced this issue Sep 26, 2022
This produces assembly which closer matches the original EXE.

Tris weren't having their depth calculated correctly. Correcting this
fixes RSDKModding#69.
Clownacy added a commit to Clownacy/RSDKv5-Decompilation-Wii-U that referenced this issue Sep 26, 2022
This produces assembly which closer matches the original EXE.

Tris weren't having their depth calculated correctly. Correcting this
fixes RSDKModding#69.
@Clownacy
Copy link
Contributor

It turns out that 2040219 only fixes some of the rendering issues described in this issue (Sonic, and a few issues with the Homers). 428eda4 fixes the rest of them.

Clownacy added a commit to Mefiresu/RSDKv5-Decompilation that referenced this issue Sep 5, 2023
Insertion sort is a stable sorting algorithm, and Mania apparently depends on the sorting being stable in order to reproduce images accurately. This issue is highlighted by Mania Repainted, as noted in this issue: RSDKModding#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rendering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants