Fix-up DrawCircle.
#111
Merged
Fix-up DrawCircle.
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was making Linux's AddressSanitizer freak out. It was also seemingly causing crashes on both PC and in my Wii U port. In the Wii U's case, the crash would consistently occur during the PGZ->SSZ transition, while on PC it seemed to be clobbering memory related to the `SDL_Renderer` pointer, causing crashes at seemingly random while browsing the main menu, and also during the PGZ->SSZ transition. Considering that the main menu uses `DrawCircle` quite a bit, there's a chance that this commit fixes Rubberduckycooly#106.
|
I don't think #106 is fixed by this fix unfortunately |
Clownacy
added a commit
to Clownacy/Sonic-Mania-Decompilation-Wii-U
that referenced
this pull request
Oct 9, 2022
Ohhhhhhh where the hell do I begin with this... Okay, so, if you complete PGZ2 while playing without Tails or Knuckles as a sidekick and while you have a Fire Shield, then the game will crash during the cutscene right when the first 'pulse' of the Phantom Ruby happens. This is caused by the shield being loaded into player 2's object slot. The cutscene tries to update both players, mistaking the shield for the sidekick character. This causes it to overwrite the shield's state with player state, causing the shield player pointer to be replaced with a pointer to a player object function. This would cause the shield object's update function to crash the game. The original code was able to tell that the second player slot had a shield in it by comparing its classID to that of the first player, but this decompilation got this incorrect and instead merely checked that the slot wasn't empty. It also redundantly checked if the pointer to the slot was `NULL`, which is impossible. Correcting this fixes the crash. Good riddance, too: that bug's been driving me crazy for over a month! I thought I'd fixed it in this PR... RSDKModding/RSDKv5-Decompilation#111 ...but it turns out that I'd just fixed a completely unrelated bug that, at the time, was crashing my MinGW builds. Because the conditions to trigger this bug were so specific (have a Fire Shield, and don't have Tails or Knuckles as a companion), I never figured out how to consistently recreate this crash until now. Aaaaaaaaaaaaaaaaaaaaa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was making Linux's AddressSanitizer freak out. It was also seemingly causing crashes on both PC and in my Wii U port.
In the Wii U's case, the crash would consistently occur during the PGZ->SSZ transition, while on PC it seemed to be clobbering memory related to the
SDL_Rendererpointer, causing crashes at seemingly random while browsing the main menu, and also during the PGZ->SSZ transition.Considering that the main menu uses
DrawCirclequite a bit, there's a chance that this commit fixes Rubberduckycooly#106.