Tweak to Audio Lock Fix (Fixes Vita Crashing as well) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the previous fix works perfectly on platforms with an officially supported SDL2 library using the recommended methods, some platforms (including the Vita) will need to still use the Legacy SDL_Lock/Unlock Audio functions to alleviate the crashes. SDL_Lock/Unlock Audio is already used in Audio.cpp as well, so this makes sure everything is consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the previous fix works perfectly on platforms with an officially supported SDL2 library using the recommended methods, some platforms (including the Vita) will need to still use the Legacy SDL_Lock/UnlockAudio functions to alleviate the crashes. SDL_Lock/UnlockAudio is already used in Audio.hpp as well, so this makes sure everything is consistent.
This should not change anything functionally for all other platforms that support SDL2.