Add missing audio locks #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TorutheRedFox
added a commit
to TorutheRedFox/Sonic-1-2-2013-Decompilation
that referenced
this pull request
Jan 25, 2021
nextvolume
added a commit
to nextvolume/Sonic-1-2-2013-Decompilation
that referenced
this pull request
Feb 1, 2021
Jdsle
added a commit
to Jdsle/RSDKv4-Decompilation
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original audio code was missing a lot of audio locks. I added them, and after playing a bunch of random songs in the sound test for a minute or two, I found no crashes. Either way, these locks should've been in place to begin with.