-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Giving the option of setting the autoStart for the "from*" functions #108
Comments
The main reason not to would be due to the planned breaking changes around / removal of autostart discussed in #25, but given that they have been sitting there for such a long time (my fault), I think it is reasonable to add such options. |
Thanks for the reply! I will make a PR this week then. |
Can't you just use the |
I did that to fix my issue. However, I feel it should be an option with those functions because it changes the behavior quite a lot, and it can be unexpected that the iterator starts "without intervention". Of course, those functions are pretty simple, so building the iterator by oneself is not difficult. So, maybe it is unnecessary, but I think we can argue that those functions as a whole might not be necessary. |
Hi everyone,
I wonder if it would fit the library's design to give functions like
fromArray
the option to set the autoStart to a user-defined value. If this is the case, I can make a PR for it.The text was updated successfully, but these errors were encountered: