Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEK removal #110

Closed
ghost opened this issue Oct 7, 2011 · 8 comments
Closed

EEK removal #110

ghost opened this issue Oct 7, 2011 · 8 comments

Comments

@ghost
Copy link

ghost commented Oct 7, 2011

Estonian kron support needs to be removed since it's no longer used in Estonia (http://www.bbc.co.uk/news/world-europe-12098513).

:eek => { :priority => 100, :iso_code => "EEK", :name => "Estonian Kroon", :symbol => "KR", :subunit => "Sent", :subunit_to_unit => 100, :symbol_first => false, :html_entity => "", :decimal_mark => ".", :thousands_separator => ","},

The same is already done in eu_central_bank gem.

@semmons99
Copy link
Member

I'm thinking we should leave this in for historical calculations. We have a number of requests for those before.

@weppos
Copy link
Member

weppos commented Oct 17, 2011

What about moving it to the currency_bc.json file?

@semmons99
Copy link
Member

That would be fine with me if someone would like to submit a patch.

@ghost
Copy link
Author

ghost commented Oct 17, 2011

What this file is used for? Could someone explain more about it?

@semmons99
Copy link
Member

It's to signify that the currency isn't valid anymore, but it still needs to be there for legacy reasons.

@weppos weppos reopened this Oct 17, 2011
@weppos
Copy link
Member

weppos commented Oct 17, 2011

That would be fine with me if someone would like to submit a patch.

I'll do.

@ghost
Copy link
Author

ghost commented Oct 17, 2011

I could do it...

@ghost
Copy link
Author

ghost commented Oct 17, 2011

weppos: OK

@ghost ghost closed this as completed Oct 17, 2011
@ghost ghost reopened this Oct 17, 2011
@weppos weppos closed this as completed in 667cc2d Oct 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants