From 7aa369c478a6b19eea7f2ae61abe79dd53a8742f Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 14 Dec 2022 09:45:58 +0100 Subject: [PATCH] Revert "ci: Apply warnings in CI" As discussed in : > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7aa18c45e7047f539b11cd572f0f9502b6d. --- .github/workflows/ccpp.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml index 8c9f027cf365..c7d27ce2fcd5 100644 --- a/.github/workflows/ccpp.yml +++ b/.github/workflows/ccpp.yml @@ -8,9 +8,6 @@ on: pull_request: branches: [ master ] -env: - CXXFLAGS: "-Wno-unused-parameter -Werror=overloaded-virtual" - jobs: build-and-check-ubuntu-64bit: