Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run failed: Build Docker image - master (28f527c) #691

Closed
tschwinge opened this issue Sep 25, 2021 · 10 comments · Fixed by #1124
Closed

Run failed: Build Docker image - master (28f527c) #691

tschwinge opened this issue Sep 25, 2021 · 10 comments · Fixed by #1124

Comments

@tschwinge
Copy link
Member

Pushed to master branch commit 28f527c "Merge commit '2961ac45b9e19523958757e607d11c5893d6368b' [#247]", and got https://github.com/Rust-GCC/gccrs/actions/runs/1272865945 in return.

@philberty
Copy link
Member

For some reason, it's not picking up our docker hub username and password secrets from the repo. Can't seem to find much info on this.

@philberty
Copy link
Member

This is now fixed the secrets needed to be part of the organisation not the repo for it to pick up the docker username and pass

@tschwinge tschwinge reopened this Oct 16, 2021
@tschwinge
Copy link
Member Author

tschwinge commented Oct 16, 2021

I'm still getting these error emails whenever I push to my own https://github.com/tschwinge/gccrs: https://github.com/tschwinge/gccrs/actions/runs/1341555112, https://github.com/tschwinge/gccrs/actions/runs/1348791814, for example. I have not set up any Docker things myself, so wouldn't expect anything Docker-y processing to happen?

@tschwinge
Copy link
Member Author

Also, upon pushing to my own https://github.com/tschwinge/gccrs, this seems to have triggered a resource-hungry GCC bootstrap build (which I've never configured), which failed for unrelated reasons, see https://github.com/tschwinge/gccrs/actions/runs/1348791815. I don't think it's a good use of (compute) resources, to be doing such builds for (presumably?) every GitHub fork of gccrs?

@philberty
Copy link
Member

Good point @tschwinge I think there are options here to limit/change the jobs for forks of the repo.

@philberty
Copy link
Member

I've added this ticket to my current plan just to keep it on my radar to see what we can do to improve the experience for forked repos.

@philberty philberty removed this from the Control Flow 2 - Pattern Matching milestone Nov 3, 2021
@philberty
Copy link
Member

@philberty philberty removed their assignment Feb 7, 2022
@tschwinge
Copy link
Member Author

Or this maybe: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-run-job-for-specific-repository?

@philberty
Copy link
Member

that looks like the perfect solution!

@philberty
Copy link
Member

Looks like #1124 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants