Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI to use -Werror #694

Closed
philberty opened this issue Sep 28, 2021 · 3 comments · Fixed by #1026
Closed

Update the CI to use -Werror #694

philberty opened this issue Sep 28, 2021 · 3 comments · Fixed by #1026

Comments

@philberty
Copy link
Member

We are using github automations for our PR's. Now that we have working bootstrap build lets avoid regressions here by adding -Werror to our CI

This is how we configure our build for CI automation in PR's

- name: Configure
run: |
mkdir -p gccrs-build;
cd gccrs-build;
../configure \
--enable-languages=rust \
--disable-bootstrap \
--enable-multilib

Let's update this to add --enable-werror to catch warnings breaking the build again.

@tschwinge
Copy link
Member

Note that GCC generally is only expected to be "warning-clean" without --disable-bootstrap (that is, default --enable-bootstrap for a native build; see #336), and not for the initial stage where it's using the "initial" compiler -- otherwise we're at the mercy of whatever "initial" compiler we're using.

@CastilloDel
Copy link
Contributor

@tschwinge In the script it says that --enable-werror only enables -Werror in bootstrap stage2 and later (check here). So it would be okay to add that and enable the bootstrap, right?

@CastilloDel
Copy link
Contributor

I made a PR, please let me know if a change is needed! 😄

@bors bors bot closed this as completed in 1d34c12 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants