Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#951 broke building for x86_64-pc-windows-gnu and i686-pc-windows-gnu #953

Closed
jrb0001 opened this issue Dec 29, 2019 · 1 comment · Fixed by #956
Closed

#951 broke building for x86_64-pc-windows-gnu and i686-pc-windows-gnu #953

jrb0001 opened this issue Dec 29, 2019 · 1 comment · Fixed by #956

Comments

@jrb0001
Copy link
Contributor

jrb0001 commented Dec 29, 2019

Output at the end:

C:/PROGRA~1/MINGW-~1/X86_64~1.0-P/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lvcruntime
collect2.exe: error: ld returned 1 exit status
mingw32-make.exe[2]: *** [CMakeFiles\SDL2.dir\build.make:2365: SDL2.dll] Error 1
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:105: CMakeFiles/SDL2.dir/all] Error 2
mingw32-make.exe: *** [Makefile:129: all] Error 2
thread 'main' panicked at '
command did not execute successfully, got: exit code: 2

build script failed, must exit now', C:\Users\jrb0001\.cargo\registry\src\jackfan.us.kg-1ecc6299db9ec823\cmake-0.1.42\src\lib.rs:861:5

It looks like the patching infrastructure needs to be extended for target specific patches or is there a better way?

@Cobrand
Copy link
Member

Cobrand commented Dec 30, 2019

I think there was a mistake in #951, the vcruntime flag should only be used in the VC toolchain and not the mingw one. You're using mingw, so you got an error there because it couldn't get the lib from the msvc toolcahin.

Basically we need to differentiate between those two and apply the correct flags in both cases, just as you said. It's a very simple PR to make, do you think you'd be able to do it?

@jrb0001 jrb0001 changed the title #951 broke building for x86_64-unknown-linux-gnu and i686-pc-windows-gnu #951 broke building for x86_64-pc-windows-gnu and i686-pc-windows-gnu Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants