Game Updates Not Auto Loading

[Horakht]

Description of the issue

I think it was working in Canary 1.2.88 but not 100% sure....anyways the issue is that when I used to download new game updates, and place them in the correct folder after deleting the old update, Ryujinx would auto detect the new update upon loading, and apply the new update automatically. Now, even though it still detects the new update, it doesn't automatically apply the new update, it defaults to the stock update/no update. I have to go to the game I updated, right-click and select "manage title updates" and manually click on the new update to apply it.

Reproduction steps

Have a newer update for a game, place that new update in your specified directory, erase your old update. Start Ryujinx and wait for your games to finish loading. A prompt will come up telling you that it found 1 new update. Close the prompt and scroll to find the game you just updated. It will be on the default version now instead of the new update.

Log file

Ryujinx_Canary_1.2.89_2024-12-12_16-17-11.log

OS

Win 11

Ryujinx version

Canary 1.2.89

Game version

No response

CPU

No response

GPU

No response

RAM

No response

List of applied mods

No response

Additional context?

No response

[gh0sti]

Just noticed this too this was working before on 1.2.76 and lower.

[Horakht]

Just noticed this too this was working before on 1.2.76 and lower.

Yes I would've hoped it would be fixed by now, just find a version it worked in, see which version broke it and bam. Unless I'm missing something lol but an inconvenience at best, still glad it auto detects the updates.

[GreemDev]

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.

I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.

Are you sure it was working on Canary 88? That one did change logic.

[gh0sti]

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.

I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.

Are you sure it was working on Canary 88? That one did change logic.

Is 1.2.78 based on canary 89?

[GreemDev]

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.
I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.
Are you sure it was working on Canary 88? That one did change logic.

Is 1.2.78 based on canary 89?

No.

[Horakht]

This is confusing. Canary 89 compared to 88 is apparently when it broke, but that version locale changes & adding a table to the GitHub releases.

I don't see how adding a markdown table to releases or Ukrainian locale changes would have removed this behavior.

Are you sure it was working on Canary 88? That one did change logic.

Im not 100% sure it was working on Canary 88, I think that is just when I noticed it. I know for sure it was working in one of the Canary 70 versions

[GreemDev]

Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround.
The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical.

I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another.

This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small...

[gh0sti]

Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround. The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical.

I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another.

This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small...

So I have been making some super xcis with my dumps and noticed that it reverts back to selecting v1 instead of the bundled update. The auto selecting of latest game update had to have broken updating from stable 1.2.76 to 1.2.78, doing a diff on those 2 versions wouldn't be helpful?

[GreemDev]

Unless I'm given a Canary where it broke I can't fix this; at least not with an ugly ass hack workaround. The reason is there's no way in the emulator code for me to know if the user chose to launch with no update or if it's just the initial state after loading available updates. Those 2 states are identical.
I don't want to ALWAYS load the latest update when you load the games list with v1 of a game selected with updates present. If you want to play V1 of games this would be annoying, and just replacing one regression in functionality with another.
This definitely raises the question how it worked fine before. It's not like I removed the code to auto-select updates on purpose, so it must have been something small...

So I have been making some super xcis with my dumps and noticed that it reverts back to selecting v1 instead of the bundled update. The auto selecting of latest game update had to have broken updating from stable 1.2.76 to 1.2.78, doing a diff on those 2 versions wouldn't be helpful?

Stable versions can have tens of commits in each one now, canary only has a few each.

[gh0sti]

@GreemDev I want to say the logic here with changes on DLC being loaded could have affected how Ryu reads game updates. "Fix missing total DLC count in the Manage DLC window."

de00a71

[GreemDev]

DownloadableContentModel refers to DLCs specifically; this code isn't touched for updates

[Horakht]

So I just tested, it was last working correctly as of Canary 1.2.80. I tried with Canary 81 and 82 and the program just crashed when trying to detect the updates I assume. And every time you reopen the program it crashes before you even get to try and change settings. So yeah 1.2.80 Canary works fine

[HH-Unix]

Canary-1.2.80 it worked well! 81 to 83, Ryujinx crashed. Maybe it's related to this code line at canary-1.2.84: {currentlySelected.Check(curr => curr.TitleUpdate?. Version < update.Version);} The "?" Has been added!

[GreemDev]

8a2bc39
Give Canary 209 a try when builds are available: https://github.com/Ryubing/Canary-Releases/releases/tag/1.2.209

[Horakht]

8a2bc39 Give Canary 209 a try when builds are available: https://github.com/Ryubing/Canary-Releases/releases/tag/1.2.209

Just tested, clean portable build, it crashes also and keeps crashing every time I load ryujinx after I added my directories

[GreemDev]

can you please give me a crash log....so i can actually fix it...

[Horakht]

Ryujinx_Canary_1.2.209_2025-01-05_15-59-04.log

[GreemDev]

Alright try out Canary 210 when it's ready

[Horakht]

Alright will post in a few minutes

[Horakht]

Everything seems to be working fine again now as of Canary 210. Thanks!