Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloads taking (ReadOnly)Memory<byte>/Span<byte> arguments #481

Closed
ArgusMagnus opened this issue May 29, 2023 · 3 comments
Closed

Add overloads taking (ReadOnly)Memory<byte>/Span<byte> arguments #481

ArgusMagnus opened this issue May 29, 2023 · 3 comments

Comments

@ArgusMagnus
Copy link
Contributor

ArgusMagnus commented May 29, 2023 •
edited
Loading

It would be great to have overloads of the ReadBytes/WriteBytes methods and their async counterparts which take Span<byte> and the like as arguments. This would enable us to read/write array slices.

If this is something you would accept, I may be able to provide a pull request for this.
@mycroes
Copy link
Member

mycroes commented May 30, 2023

I'm definitely open to accepting those. Feel free to submit a PR when you're up to it.

@ArgusMagnus
Copy link
Contributor Author

I created the pull request #482

@mycroes
Copy link
Member

mycroes commented May 30, 2023

Fixed by #482, released as part of v0.17.0.

@mycroes mycroes closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mycroes @ArgusMagnus