Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-face declarations must not use CSS variables for the src attribute #267

Closed
petermuessig opened this issue Jan 6, 2023 · 3 comments
Closed

Comments

@petermuessig
Copy link
Contributor

As reported by Hira Kshetry in the OpenUI5 Slack: https://openui5.slack.com/archives/C0A7MHSSJ/p1672783549112489, Icon Fonts don't work when using CSS variables.

I remember we discussed in the past, that the font-face declaration don't support variables in the src attribute. In this case, we might exclude the font-face declarations from the replacement with the CSS variables, when using less variables inside and furthermore manifest the concrete property value.

We should verify this part with the font-face and then adopt the plugin dependent on the result.

@i556484
Copy link
Member

i556484 commented Jan 6, 2023

Related internal incident: 2270189546

@matz3
Copy link
Member

matz3 commented Jan 9, 2023

Should be fixed via #257. Or is there something else not working?

@matz3
Copy link
Member

matz3 commented Feb 14, 2023

Closing as it's already solved via #257

@matz3 matz3 closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants