Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element.before/element.after doesn't consider all possible tainted strings #202

Open
vladidx opened this issue Feb 20, 2024 · 0 comments
Open

Comments

@vladidx
Copy link
Member

vladidx commented Feb 20, 2024

The new Foxhound version introduced tainted strings as part of DOM node elements (in case innerHTML and similar is leading to DOM parsing). It seems that tainted strings are only propagated into attribute values but there are other node types which would require string propagation, e.g., comment/text/CDATA nodes but also regular element nodes where the tag name and attribute keys might be determined by tainted strings.

Example for an unrecognized flow of a comment node into sink element.after via innerHTML:
templateElement.innerHTML = '<div id="abc"><!-- Data for TAINTED --></div>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant