Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XHR response JSON Sink #80

Open
tmbrbr opened this issue Nov 24, 2022 · 0 comments
Open

Add XHR response JSON Sink #80

tmbrbr opened this issue Nov 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@tmbrbr
Copy link
Contributor

tmbrbr commented Nov 24, 2022

At the moment we only taint XHR response bodies which are returned as text.

However, XHR responses can also contain JSON content: https://xhr.spec.whatwg.org/#the-response-attribute

In this case, we need to make sure that this function is marked as a source: https://github.com/SAP/project-foxhound/blob/main/dom/xhr/XMLHttpRequestMainThread.cpp#L631

And add a StringTaint argument to the JS_ParseJSON API.
@tmbrbr tmbrbr added the enhancement New feature or request label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmbrbr