From 292b4549143037d7a8e034ca0978d55e93f10d64 Mon Sep 17 00:00:00 2001
From: Yavor Ivanov <d3xter666@users.noreply.github.com>
Date: Tue, 7 Feb 2023 09:48:13 +0200
Subject: [PATCH] [FIX] Validator contructor checks (#567)

Validate schemaName properly based on the enum by fixing a typo in tests & correcting the logical expression
---
 lib/validation/validator.js      | 2 +-
 test/lib/validation/validator.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/validation/validator.js b/lib/validation/validator.js
index 1f8740db6..d994d41fe 100644
--- a/lib/validation/validator.js
+++ b/lib/validation/validator.js
@@ -19,7 +19,7 @@ export const SCHEMA_VARIANTS = {
 
 class Validator {
 	constructor({Ajv, ajvErrors, schemaName}) {
-		if (!schemaName && !SCHEMA_VARIANTS[schemaName]) {
+		if (!schemaName || !SCHEMA_VARIANTS[schemaName]) {
 			throw new Error(
 				`"schemaName" is missing or incorrect. The available schemaName variants are ${Object.keys(
 					SCHEMA_VARIANTS
diff --git a/test/lib/validation/validator.js b/test/lib/validation/validator.js
index dc23e9956..858ce8b3e 100644
--- a/test/lib/validation/validator.js
+++ b/test/lib/validation/validator.js
@@ -88,7 +88,7 @@ test("Validator requires a valid schemaName", (t) => {
 	const Ajv = sinon.stub();
 	const ajvErrors = sinon.stub();
 	const invalidContructor = () => {
-		new Validator({Ajv, ajvErrors, schemName: "invalid schema name"});
+		new Validator({Ajv, ajvErrors, schemaName: "invalid schema name"});
 	};
 
 	t.throws(invalidContructor, {