[FIX] TaskUtil: Provide framework configuration getters to custom tasks #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Feb 15, 2023
…om tasks This was missed to add to the initial 3.0.0 release. Also see SAP/ui5-project#580 Additionally, for the Project#getReader function, default the 'style' parameter to 'runtime'. We expect this match best with custom middleware expectations, since ui5-server itself uses the same style.
This was missed to add to the initial 3.0.0 release
RandomByte
force-pushed
the
taskUtil-get-framework-configs
branch
from
ac42f20 to
8300328
Compare
flovogt
requested changes
Feb 16, 2023
flovogt
approved these changes
Feb 16, 2023
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Feb 16, 2023
…om tasks (#579) This was missed to add to the initial 3.0.0 release. Also see SAP/ui5-project#580 Additionally, for the Project#getReader function, default the 'style' parameter to 'runtime'. We expect this match best with custom middleware expectations, since ui5-server itself uses the same style. Co-authored-by: Florian Vogt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed to add to the initial 3.0.0 release