[FEATURE] Sapui5MavenSnapshotResolver: Expose cacheMode parameter through all APIs #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rough all APIs This allows consumers to control the cache behavior when using SNAPSHOT versions. Also, remove unused 'resolverConfig' option from ui5Framework
RandomByte
force-pushed
the
add-resolver-cache-mode-param
branch
from
ee0358b to
fafa114
Compare
flovogt
reviewed
May 2, 2023
matz3
requested changes
May 3, 2023
matz3
reviewed
May 4, 2023
lib/graph/graph.js
Outdated
| @@ -93,14 +95,16 @@ export async function graphFromPackageDependencies({ | |||
| * Configuration file to use for the root module instead the default ui5.yaml. Either a path relative to | |||
| * <code>cwd</code> or an absolute path. In both case, platform-specific path segment separators must be used. | |||
| * @param {string} [options.versionOverride] Framework version to use instead of the one defined in the root project | |||
| * @param {module:@ui5/project/ui5Framework/maven/CacheMode} [options.cacheMode] | |||
| * Cache mode to use when consuming SNAPSHOT versions | |||
lib/graph/graph.js
Outdated
| @@ -143,14 +147,16 @@ export async function graphFromStaticFile({ | |||
| * Configuration file to use for the root module instead the default ui5.yaml. Either a path relative to | |||
| * <code>cwd</code> or an absolute path. In both case, platform-specific path segment separators must be used. | |||
| * @param {string} [options.versionOverride] Framework version to use instead of the one defined in the root project | |||
| * @param {module:@ui5/project/ui5Framework/maven/CacheMode} [options.cacheMode] | |||
| * Cache mode to use when consuming SNAPSHOT versions | |||
| @@ -177,7 +178,7 @@ test.serial("enrichProjectGraph: without framework configuration", async (t) => | |||
|
|
|||
| test.serial("enrichProjectGraph SNAPSHOT", async (t) => { | |||
| const {sinon, ui5Framework, utils, Sapui5MavenSnapshotResolverInstallStub} = t.context; | |||
| process.env.UI5_MAVEN_SNAPSHOT_ENDPOINT = "__url__"; | |||
| process.env.UI5_MAVEN_SNAPSHOT_ENDPOINT_URL = "__url__"; | |||
There was a problem hiding this comment.
Is this even required within this test? I wonder why it didn't fail before, as the variable has been renamed already.
matz3
approved these changes
May 4, 2023
RandomByte
changed the title
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jun 2, 2023
Expose cache-mode API parameter via CLI. See also: SAP/ui5-project#607
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jun 5, 2023
Expose cache-mode API parameter via CLI. See also: SAP/ui5-project#607
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jun 5, 2023
Expose cache-mode API parameter via CLI. See also: SAP/ui5-project#607 --------- Co-authored-by: Günter Klatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows consumers to control the cache behavior when using
SNAPSHOT versions