[FIX] Workspace: Ignore empty npm workspace modules #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dynamic npm workspaces[1] configuration resolves to a directory lacking a package.json file, ignore that module silently. This can happen when using a pattern like "packages/*" in the workspaces configuration, and then deleting a package. In case files on .gitignore remain in the directory for some users, the physical directory is not removed by git. This lead to issues for UI5 Tooling, trying to use the empty directory and throwing because of the lacking package.json. With this change, an error is only thrown if the module path is explicitly configured (no pattern). [1] https://docs.npmjs.com/cli/v9/using-npm/workspaces?v=true
flovogt
previously approved these changes
May 23, 2023
matz3
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dynamic npm workspaces[1] configuration resolves to a directory
lacking a package.json file, ignore that module silently.
This can happen when using a pattern like "packages/*" in the workspaces
configuration, and then deleting a package. In case files on .gitignore
remain in the directory for some users, the physical directory is not
removed by git. This lead to issues for UI5 Tooling, trying to use the
empty directory and throwing because of the lacking package.json.
With this change, an error is only thrown if the module path is
explicitly configured (no pattern).
[1] https://docs.npmjs.com/cli/v9/using-npm/workspaces?v=true