[FIX] serveResources: Correctly encode non UTF-8 resources #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replaceStream module converts all string it processes to UTF-8. Therefore, stop using it for strings that are not UTF-8 encoded. Resolves https://github.com/SAP/ui5-server/issues/196
codeworrior
previously approved these changes
Jun 18, 2019
| "Correct content type and charset"); | ||
|
|
||
| t.deepEqual(res.body.toString("latin1"), "showHelloButtonText=Say ä!", "Correct response"); | ||
| // Because it took so long to figure this out I keep the below line. It is equivalent to the deepEqual above |
There was a problem hiding this comment.
This comment makes me curious: what did you want to achieve with that line?
There was a problem hiding this comment.
Well, now it seems pretty clear. But I first struggled converting res.text (without calling .responseType("arraybuffer") form latin1 to UTF-8. I did not get that working.
I still find it a bit confusing that I have a raw Buffer, containing some latin1 encoded characters, that I can only convert to a UTF-8 string by calling .toString("latin1").
RandomByte
force-pushed
the
handle-non-utf8-encoded-resources
branch
from
5eb629e to
a66337d
Compare
matz3
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replaceStream module converts all string it processes to UTF-8.
Therefore, stop using it for strings that are not UTF-8 encoded.
Resolves https://github.com/SAP/ui5-server/issues/196