Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck encoding of i18n files #161

Closed
2 of 6 tasks
lukasriederle opened this issue Jul 4, 2019 · 3 comments
Closed
2 of 6 tasks

Recheck encoding of i18n files #161

lukasriederle opened this issue Jul 4, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@lukasriederle
Copy link

Expected Behavior

i18n files should be readable in UTF8 at least as option

Current Behavior

utf8 files get read with wrong character set what leads to issues with e.g. German umlauts
Especially this is an issue in combination with SAP Translation Hub witch is translating into UTF8
using a manual conversion is not an option for bigger projects with many languages.
https://github.com/SAP/ui5-builder/issues/105

Steps to reproduce the issue

see https://github.com/SAP/ui5-builder/issues/105

Context

see https://github.com/SAP/ui5-builder/issues/105

Affected components (if known)

Log Output / Stack Trace

see https://github.com/SAP/ui5-builder/issues/105

@htammen
Copy link

htammen commented Jul 5, 2019

I opened a similar issue in ui5-server. This was fixed with ui5-cli version 1.5.3.
Probably this is helpful for you, too.
https://github.com/SAP/ui5-server/issues/196

@matz3
Copy link
Member

matz3 commented Jul 16, 2019

We are currently working on a concept to better handle encoding of properties files: #168

@matz3 matz3 self-assigned this Jul 23, 2019
@matz3 matz3 added the enhancement New feature or request label Jul 23, 2019
@RandomByte
Copy link
Member

With UI5 CLI v1.7.0, you can now configure UTF-8 as the source encoding of a projects *.properties files. The default stays at ISO-8859-1. In both cases the UI5 Tooling will escape any non-ASCII characters, so that the build result is independent from the encoding.

📖 Documentation (see propertiesFileSourceEncoding)
🔎 Demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants