Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom bundles should not contain unwanted debug-resources #513

Closed
RandomByte opened this issue Apr 1, 2021 · 3 comments
Closed

Custom bundles should not contain unwanted debug-resources #513

RandomByte opened this issue Apr 1, 2021 · 3 comments
Assignees
Labels
bug Something isn't working module/ui5-builder Related to the UI5 Builder module

Comments

@RandomByte
Copy link
Member

RandomByte commented Apr 1, 2021

Expected Behavior

Custom bundles should never contain debug files generated during the build of dependencies.

To be checked: What about "debug bundles"?

Current Behavior

Custom bundles using wildcards in their configuration might include debug resources of dependencies if dependencies are built as well (--all).

Steps to Reproduce the Issue

  1. Clone the openui5-sample-app

  2. Add the following configuration to the ui5.yaml

    builder:
      bundles:
        - bundleDefinition:
            name: my-bundle.js
            sections:
              - mode: provided
                filters: []
              - mode: preload
                name: bundle
                filters:
                  - sap/ui/core/
  3. Execute ui5 build --all --clean-dest

  4. ⚠️ The generated bundle at dist/resources/my-bundle.js contains debug files of the sap/ui/core namespace like sap/ui/core/AppCacheBuster-dbg.js

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 2.10.2
  • Node.js Version: v15.12.0
  • npm Version: 7.6.3
  • OS/Platform: macOS
  • Browser (if relevant): -
  • Other information regarding your environment (optional): nothing

Log Output / Stack Trace

{...}
@RandomByte RandomByte added bug Something isn't working needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Apr 1, 2021
@RandomByte
Copy link
Member Author

Additional info from today's sync: The Maven bundling filters out debug resources for which a non-debug version can be found, unless explicitly requested to prefer debug resources.

@RandomByte RandomByte changed the title Custom bundles can contain unwanted debug-resources Custom bundles should not contain unwanted debug-resources Apr 13, 2021
@RandomByte RandomByte added module/ui5-builder Related to the UI5 Builder module and removed needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Apr 13, 2021
@RandomByte
Copy link
Member Author

Tracking internally as CPOUI5FOUNDATION-333

@tobiasso85 tobiasso85 assigned matz3 and unassigned matz3 May 3, 2021
@RandomByte RandomByte self-assigned this May 28, 2021
@RandomByte
Copy link
Member Author

Fixed in next (UI5 Tooling 3.0) via SAP/ui5-builder#666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module/ui5-builder Related to the UI5 Builder module
Projects
None yet
Development

No branches or pull requests

2 participants