fix(ui5-upload-collection): change file deleted event name (#3413)

Part of #3107 BREAKING_CHANGE: The "file-deleted "event" is renamed to "item-delete"
SAP · Jun 8, 2021 · 5898eb8 · 5898eb8
1 parent 6104b80
commit 5898eb8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/fiori/src/UploadCollection.js b/packages/fiori/src/UploadCollection.js
@@ -150,11 +150,11 @@ const metadata = {
 		 * <br><br>
 		 * <b>Note:</b> A Delete button is displayed on each item,
 		 * when the <code>ui5-upload-collection</code> <code>mode</code> property is set to <code>Delete</code>.
-		 * @event sap.ui.webcomponents.fiori.UploadCollection#file-deleted
+		 * @event sap.ui.webcomponents.fiori.UploadCollection#item-delete
 		 * @param {HTMLElement} item The <code>ui5-upload-collection-item</code> which was renamed.
 		 * @public
 		 */
-		"file-deleted": {
+		"item-delete": {
 			detail: {
 				item: { type: HTMLElement },
 			},
@@ -294,7 +294,7 @@ class UploadCollection extends UI5Element {
 	}
 
 	_onItemDelete(event) {
-		this.fireEvent("file-deleted", { item: event.detail.item });
+		this.fireEvent("item-delete", { item: event.detail.item });
 	}
 
 	_onSelectionChange(event) {

diff --git a/packages/fiori/test/pages/uploadCollectionScript.js b/packages/fiori/test/pages/uploadCollectionScript.js
@@ -65,7 +65,7 @@
 		document.getElementById("fileUploader").value = "";
 	});
 
-	uploadCollection.addEventListener("ui5-selectionChange", function (event) {
+	uploadCollection.addEventListener("ui5-selection-change", function (event) {
 		var selectedItems = event.detail.selectedItems.reduce(function (acc, item) {
 			return acc + item.fileName + ",";
 		}, "[");
@@ -75,7 +75,7 @@
 		document.getElementById("selectedItems").innerText = selectedItems;
 	});
 
-	uploadCollection.addEventListener("ui5-fileDeleted", function (event) {
+	uploadCollection.addEventListener("ui5-item-delete", function (event) {
 		uploadCollection.removeChild(event.detail.item)
 	});
 

diff --git a/packages/fiori/test/specs/UploadCollection.spec.js b/packages/fiori/test/specs/UploadCollection.spec.js
@@ -64,7 +64,7 @@ describe("UploadCollection", () => {
 			assert.strictEqual(parseInt(browser.$("#renamedFileIndex").getText()), secondItemIndex, "renamed file index should be updated after rename")
 		});
 
-		it("upload collection should fire 'fileDeleted'", () => {
+		it("upload collection should fire 'item-delete'", () => {
 			const uploadCollection = browser.$("#uploadCollection");
 			const firstItem = browser.$("#firstItem");
 
@@ -75,7 +75,7 @@ describe("UploadCollection", () => {
 			const deleteBtn = firstItem.shadow$(".ui5-li-deletebtn");
 			deleteBtn.click();
 
-			assert.strictEqual(uploadCollection.getProperty("items").length, 4, "item should be deleted when 'fileDeleted' event is fired");
+			assert.strictEqual(uploadCollection.getProperty("items").length, 4, "item should be deleted when 'item-delete' event is fired");
 		});
 
 		it("item should fire 'retry'", () => {