Skip to content

Commit

Permalink
fix(ui5-wizard): remove unneeded aria properties (#4262)
Browse files Browse the repository at this point in the history
- Remove accessible-name on Wizard level as it is unneeded, the region has a default aria-label and the wizard itself should be used along with a page with title.
- Remove accessible-name and accessible-name-ref from Wizard Step, as it does not work and also again not needed. The wizard step title is used as a label of the element.

BREAKING CHANGE: accessible-name has been removed
  • Loading branch information
elenastoyanovaa authored Nov 4, 2021
1 parent 00c308f commit 7fa969b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 37 deletions.
15 changes: 1 addition & 14 deletions packages/fiori/src/Wizard.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,6 @@ const metadata = {
tag: "ui5-wizard",
managedSlots: true,
properties: /** @lends sap.ui.webcomponents.fiori.Wizard.prototype */ {
/**
* Sets the accessible aria name of the component.
*
* @type {String}
* @defaultvalue undefined
* @public
* @since 1.0.0-rc.15
*/
accessibleName: {
type: String,
defaultValue: undefined,
},

/**
* Defines the width of the <code>ui5-wizard</code>.
* @private
Expand Down Expand Up @@ -806,7 +793,7 @@ class Wizard extends UI5Element {
}

get ariaLabelText() {
return this.accessibleName || Wizard.i18nBundle.getText(WIZARD_NAV_ARIA_ROLE_DESCRIPTION);
return Wizard.i18nBundle.getText(WIZARD_NAV_ARIA_ROLE_DESCRIPTION);
}

get effectiveStepSwitchThreshold() {
Expand Down
23 changes: 0 additions & 23 deletions packages/fiori/src/WizardStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,29 +99,6 @@ const metadata = {
branching: {
type: Boolean,
},

/**
* Sets the accessible aria name of the component.
*
* @type {String}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.15
*/
accessibleName: {
type: String,
},

/**
* Defines the aria-labelledby of the step.
* @type {String}
* @defaultvalue ""
* @public
* @since 1.0.0-rc.15
*/
accessibleNameRef: {
type: String,
},
},
slots: /** @lends sap.ui.webcomponents.fiori.WizardStep.prototype */ {
/**
Expand Down

0 comments on commit 7fa969b

Please sign in to comment.