diff --git a/packages/main/src/ColorPalette.hbs b/packages/main/src/ColorPalette.hbs index 8492f649183d..065dda651330 100644 --- a/packages/main/src/ColorPalette.hbs +++ b/packages/main/src/ColorPalette.hbs @@ -1,12 +1,13 @@ -
+ aria-label="{{colorContainerLabel}}" + @click={{_onclick}} + @keyup={{_onkeyup}} + @keydown={{_onkeydown}}> {{#each this.displayedColors}} + > {{/each}}
\ No newline at end of file diff --git a/packages/main/src/ColorPalette.js b/packages/main/src/ColorPalette.js index 0d870191dfbb..01ba005fa2c6 100644 --- a/packages/main/src/ColorPalette.js +++ b/packages/main/src/ColorPalette.js @@ -143,7 +143,9 @@ class ColorPalette extends UI5Element { } _onclick(event) { - this.selectColor(event.target); + if(event.target.localName === "ui5-color-palette-item") { + this.selectColor(event.target); + } } _onkeyup(event) { diff --git a/packages/main/src/ColorPaletteItem.hbs b/packages/main/src/ColorPaletteItem.hbs index a917603dff64..604947e88a0d 100644 --- a/packages/main/src/ColorPaletteItem.hbs +++ b/packages/main/src/ColorPaletteItem.hbs @@ -1,5 +1,5 @@
{ browser.url("http://localhost:8080/test-resources/pages/ColorPalette.html"); const colorPalette = browser.$("#cp1"); const colorPaletteEntries = colorPalette.$$("[ui5-color-palette-item]"); - const swatch = colorPaletteEntries[0]; + const item = colorPaletteEntries[0]; - swatch.click(); + item.click(); - swatch.keys("ArrowRight"); - swatch.keys("Space"); + item.keys("ArrowRight"); + item.keys("Space"); assert.strictEqual(colorPalette.getProperty("value"), "pink", "Check if selected value is pink"); }); @@ -31,12 +31,12 @@ describe("ColorPalette interactions", () => { browser.url("http://localhost:8080/test-resources/pages/ColorPalette.html"); const colorPalette = browser.$("#cp1"); const colorPaletteEntries = colorPalette.$$("[ui5-color-palette-item]"); - const swatch = colorPaletteEntries[0]; + const item = colorPaletteEntries[0]; - swatch.click(); + item.click(); - swatch.keys("ArrowLeft"); - swatch.keys("Space"); + item.keys("ArrowLeft"); + item.keys("Space"); colorPalette.keys("Space"); @@ -47,12 +47,12 @@ describe("ColorPalette interactions", () => { browser.url("http://localhost:8080/test-resources/pages/ColorPalette.html"); const colorPalette = browser.$("#cp1"); const colorPaletteEntries = colorPalette.$$("[ui5-color-palette-item]"); - const swatch = colorPaletteEntries[0]; + const item = colorPaletteEntries[0]; - swatch.click(); + item.click(); - swatch.keys("ArrowUp"); - swatch.keys("Space"); + item.keys("ArrowUp"); + item.keys("Space"); assert.strictEqual(colorPalette.getProperty("value"), "orange", "Check if selected value is orange"); }); @@ -61,12 +61,12 @@ describe("ColorPalette interactions", () => { browser.url("http://localhost:8080/test-resources/pages/ColorPalette.html"); const colorPalette = browser.$("#cp1"); const colorPaletteEntries = colorPalette.$$("[ui5-color-palette-item]"); - const swatch = colorPaletteEntries[9]; + const item = colorPaletteEntries[9]; - swatch.click(); + item.click(); - swatch.keys("ArrowDown"); - swatch.keys("Space"); + item.keys("ArrowDown"); + item.keys("Space"); assert.strictEqual(colorPalette.getProperty("value"), "darkblue", "Check if selected value is darkblue"); });