Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-title: Default size has changed with 2.X Upgrade? #10225

Closed
1 task done
MFel0123 opened this issue Nov 21, 2024 · 2 comments
Closed
1 task done

ui5-title: Default size has changed with 2.X Upgrade? #10225

MFel0123 opened this issue Nov 21, 2024 · 2 comments

Comments

@MFel0123
Copy link

Bug Description

Hello colleagues,
when checking the changes to introduce Web Components 2.x (in this case: 2.4 to be exact) I have the impression that the standard size of the ui5-title (the default) has been changed: in 1.x it appeared bigger (I guess it would be size=H2). Now the new default is "size=H5". So this is much smaller.
I did not find this change documented here in the migration guide:
https://sap.github.io/ui5-webcomponents/docs/migration-guides/to-version-2/#ui5-title
Please correct me if I am wrong or take it as an issue.
Kind Regards

Affected Component

ui5-title

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

  1. Just check the default title appearance in different UI5 Webcomponent versions.

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.4

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@MFel0123 MFel0123 added the bug This issue is a bug in the code label Nov 21, 2024
@MFel0123 MFel0123 changed the title ui5-title: Default size has changed with 2.0 Upgrade? ui5-title: Default size has changed with 2.X Upgrade? Nov 21, 2024
@ivoplashkov ivoplashkov self-assigned this Nov 21, 2024
@ivoplashkov
Copy link
Member

ivoplashkov commented Nov 21, 2024

Hello colleagues,

The default value of the level property of the ui5-title component has been changed with version 2, but was not mentioned in the migration guide.

Could you please confirm that this was intentional change?

Thank you and regards,
Ivaylo

@ivoplashkov ivoplashkov removed their assignment Nov 22, 2024
@GerganaKremenska
Copy link
Member

Hello @MFel0123,

Thank you for raising your issue!
With 2.0 we introduced a "size" property, which influences the visual size of the ui5-title.

This is an intentional change and the component is by design.

Thank you and regards,
Gergana

@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic RD Nov 26, 2024
@GerganaKremenska GerganaKremenska added consulting and removed bug This issue is a bug in the code labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

3 participants