Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-time-picker): Improve component based on user testing #10577

Merged
merged 18 commits into from
Jan 29, 2025

Conversation

NHristov-sap
Copy link
Contributor

@NHristov-sap NHristov-sap commented Jan 16, 2025

There was user testing that gave some directions what to improve in <ui5-time-picker> component.

The following points are covered with this PR:

  • improved 24 hrs clock dial
  • clickable dots in "minutes" and "seconds" view
  • hover over the dots result in displayed hover number
  • animation - speed up animation

JIRA: BGSOFUIBALKAN-7962

@NHristov-sap NHristov-sap requested a review from hinzzx January 20, 2025 09:22
Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests ?

packages/main/src/TimePickerClock.ts Outdated Show resolved Hide resolved
packages/main/src/themes/TimePickerClock.css Outdated Show resolved Hide resolved
packages/main/src/TimeSelectionClocks.ts Outdated Show resolved Hide resolved
packages/main/src/TimeSelectionClocks.ts Show resolved Hide resolved
packages/main/src/themes/TimePickerClock.css Outdated Show resolved Hide resolved
packages/main/src/TimePickerClockTemplate.tsx Show resolved Hide resolved
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation runs when opening the popup

@vladitasev
Copy link
Contributor

Bug: open the time picker, press "Tab" once, check the console:
image

@NHristov-sap NHristov-sap merged commit e687547 into main Jan 29, 2025
10 checks passed
@NHristov-sap NHristov-sap deleted the BL_timepicker_animations branch January 29, 2025 12:48
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.7.0-rc.2 🎉

The release is available on v2.7.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants