Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): CSS Vars in Static Styles work on IE11 #1440

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Apr 7, 2020

The createComponentStyleTag method did not take into account Static Area CSS and did not inject it in the head. Instead, this CSS went to the ui5-static-area-item like on normal browsers. However, it wasn't processed there so CSS vars were not replaced.

The fix:

  • Do not inject any CSS in _updateFragment for IE11 (if shadyDOM is true).
  • Inject the static area CSS along with the normal CSS in createComponentStyleTag instead, where it will be processed like the regular CSS
  • Finally, add a static getter for static area CSS in UI5Element.js to ensure it's always a string.

@ilhan007 ilhan007 merged commit b8ae60e into master Apr 7, 2020
@ilhan007 ilhan007 deleted the fix-ie-static-styles branch April 7, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants