fix(framework): CSS Vars in Static Styles work on IE11 #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createComponentStyleTag
method did not take into account Static Area CSS and did not inject it in the head. Instead, this CSS went to theui5-static-area-item
like on normal browsers. However, it wasn't processed there so CSS vars were not replaced.The fix:
_updateFragment
for IE11 (ifshadyDOM
istrue
).createComponentStyleTag
instead, where it will be processed like the regular CSSUI5Element.js
to ensure it's always a string.