Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-multi-combobox: shows wrong selection when selecting item via whitespace #1487

Closed
MarcusNotheis opened this issue Apr 15, 2020 · 1 comment · Fixed by #1519
Closed

ui5-multi-combobox: shows wrong selection when selecting item via whitespace #1487

MarcusNotheis opened this issue Apr 15, 2020 · 1 comment · Fixed by #1519
Labels
bug This issue is a bug in the code

Comments

@MarcusNotheis
Copy link
Collaborator

Describe the bug
The MultiComboBox shows a wrong selected value in the suggestion list when an mcb-item was selected by clicking right of the text. Then the first item is always selected until you search again for the selected item.

To reproduce
Steps to reproduce the behavior:

  1. Open the provided codesandbox
  2. Open the MultiComboBox and search for USA
  3. Select USA by clicking somewhere in the whitespace right of the text USA
  4. Open the list again and you will see that empty is selected --> bug
  5. Search for Germany: Appears as selected --> bug
  6. Search for Bulgaria: Appears as selected --> bug
  7. You can search for any other value than USA: Always the first item is selected --> bug
  8. Search for USA
  9. Now the combo box is in sync again.

Isolated example
https://codesandbox.io/s/ui5-webcomponents-goblg?file=/index.html

Expected behavior
The MultiComboBox should only show the selected items as selected.

Screenshots
If applicable, add screenshots to help explain your problem.
Screen-Recording-2020-04-15-at-16 16 22

Context

  • UI5 Web Components version: 1.0.0-rc.6

Affected components (if known)
ui5-multi-combobox
@ilhan007 ilhan007 added the bug This issue is a bug in the code label Apr 19, 2020
@MarcusNotheis MarcusNotheis mentioned this issue Apr 22, 2020
Closed
@MarcusNotheis
Copy link
Collaborator Author

Same issue occurs for keyboard navigation as well: SAP/ui5-webcomponents-react#448

@vladitasev vladitasev mentioned this issue Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug in the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(framework): reliably re-render lists of DOM nodes SAP/ui5-webcomponents
2 participants
@MarcusNotheis @ilhan007