Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework): CLDR location can now be specified #1687

Merged
merged 1 commit into from
May 27, 2020
Merged

feat(framework): CLDR location can now be specified #1687

merged 1 commit into from
May 27, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented May 26, 2020 •
edited
Loading

The asset registry: @ui5/webcomponents-base/dist/AssetRegistry.js now exports a new method:

registerCldrMappingFunction

that can be used to specify custom paths to the CLDR assets whenever they are not bundled.

Example usage:

import { registerCldrMappingFunction } from "@ui5/webcomponents-base/dist/AssetRegistry.js";

registerCldrMappingFunction(locale => {
	return `https://unpkg.com/@ui5/[email protected]/dist/generated/assets/cldr/${locale}.json`
});

closes: #1524

@vladitasev vladitasev mentioned this pull request May 26, 2020
Closed
@vladitasev vladitasev merged commit 168e505 into master May 27, 2020
@vladitasev vladitasev deleted the cldr-asset-mapping-function branch May 27, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

@pskelin pskelin Awaiting requested review from pskelin

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customize the url where to load font and localization json files
2 participants
@vladitasev @ilhan007