Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-textarea): Add missing dependency, extract .hbs partial #1909

Merged
merged 1 commit into from
Jul 8, 2020
Merged

fix(ui5-textarea): Add missing dependency, extract .hbs partial #1909

merged 1 commit into from
Jul 8, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Jul 6, 2020 •
edited
Loading

This change:

  • fixes missing Popover.js dependency due to value state
  • adds a new partial that can be used for third-party development

For example, it would be possible to create a text area with a "clear button":
image

closes: #1879

@vladitasev vladitasev merged commit 25ed25f into master Jul 8, 2020
@vladitasev vladitasev deleted the fix-textarea-missing-dep branch July 8, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
Autopilot for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom ui5 textarea property
2 participants
@vladitasev @ilhan007