feat(ui5-time-picker): improve keyboard handling support #2092
Conversation
ilhan007
changed the title
There was a problem hiding this comment.
There are two cases of using PageDown and PageUp - when the picker is open and it is closed.
-
When it is closed, the event should be fired and the value should be changed.
*This is done in the current PR. -
When the picker is open, the value in the input field should not be changed, the event should not be fired.
Note: What happens when the picker is open.
(1) Upon ArrowDown and Up the sliders are moving up and down by one and (2) upon PageDown/Up the sliders move to the max and min value.
*Currently in this PR, the value is always changed, the event is always fired, and check if the interaction "upon PageDown/Up the sliders move to the max and min value" is in place.
I used this examples for reference: https://openui5nightly.hana.ondemand.com/entity/sap.m.TimePicker/sample/sap.m.sample.TimePicker
There was a problem hiding this comment.
Just last thing. it is good to have the keyboard handling described, otherwise the users would not even know what the component is capable of.
Please add keyboard handling section after "formatting" and before "ES6 Module Import" ones.
<h3>Keyboard handling</h3>
PageUp: Hours + 1, PageDown: Hours - 1, PageUp + Shift : Minutes + 1 PageDown + Shift: Minutes - 1, PageUp + Shift + Ctrl: Seconds + 1, PageDown + Shift + Ctrl: Seconds - 1 Related to: #1534
Fixed one keyboard handling bug and added new features:
Related to: #1534